Re: [PATCH 21/22] aacraid: use scsi_get_internal_cmd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/29/20 3:08 PM, John Garry wrote:

      return fibptr;
  }
@@ -240,36 +231,28 @@ struct fib *aac_fib_alloc_tag(struct aac_dev *dev, struct scsi_cmnd *scmd)
  /**
   *    aac_fib_alloc    -    allocate a fib
   *    @dev: Adapter to allocate the fib for
+ *    @direction: DMA data direction
   *
   *    Allocate a fib from the adapter fib pool. If the pool is empty we
   *    return NULL.
   */
-struct fib *aac_fib_alloc(struct aac_dev *dev)
+struct fib *aac_fib_alloc(struct aac_dev *dev, int direction)
  {
-    struct fib * fibptr;
+    struct scsi_cmnd *scmd;
+    struct fib * fibptr = NULL;
      unsigned long flags;
+
      spin_lock_irqsave(&dev->fib_lock, flags);

Do you still require this spinlock'ing?

No, indeed not. Will be removing them.

Cheers,

Hannes
--
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@xxxxxxx                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux