On Sun, Jun 21, 2020 at 06:24:36PM +0000, Satya Tangirala wrote: > > > Today, chipset vendors are using a different scheme for their IE. > > Need their ack before reviewing your patches. > > > Sure :). The Inline Encryption patches (the block layer, fscrypt, f2fs, > ext4 and these UFS patches) have been part of the Android common kernel > https://android.googlesource.com/kernel/common/ > for quite a while now, and chipset vendors have been working with us > on ensuring that their UFS cards are supported by these patches (by adding > code similar to Eric's RFC: Inline crypto support on DragonBoard 845c at > https://www.spinics.net/lists/linux-scsi/msg141472.html > or Mediatek's "scsi: ufs-mediatek: add inline encryption support" at > https://lkml.kernel.org/linux-scsi/20200304022101.14165-1-stanley.chu@xxxxxxxxxxxx/ > for their individual chipsets). Just as a practical matter, I don't think this patchset should be blocked waiting for a formal Acked-by from every vendor, as some of them don't to be participating in LKML at all despite being Cc'ed on these patches for a year and working with us outside LKML to support their hardware using the new framework. So I think a formal Acked-by on LKML is not always guaranteed. (It would certainly be preferable if everyone would participate though!) - Eric
