Thanks Avri for CCing me. > -----Original Message----- > From: Avri Altman <Avri.Altman@xxxxxxx> > Sent: 21 June 2020 18:05 > To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>; Satya Tangirala > <satyat@xxxxxxxxxx>; alim.akhtar@xxxxxxxxxxx; asutoshd@xxxxxxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; Barani Muthukumaran > <bmuthuku@xxxxxxxxxxxxxxxx>; Kuohong Wang > <kuohong.wang@xxxxxxxxxxxx>; Kim Boojin <boojin.kim@xxxxxxxxxxx> > Subject: RE: [PATCH v2 0/3] Inline Encryption support for UFS > > +Alim & Asutosh > > Hi Satya, > > > > > Avri, > > > > > This patch series adds support for inline encryption to UFS using > > > the inline encryption support in the block layer. It follows the > > > JEDEC UFSHCI v2.1 specification, which defines inline encryption for UFS. > > > > I'd appreciate it if you could review this series. > > > > Thanks! > > > > -- > > Martin K. Petersen Oracle Linux Engineering > A quick question and a comment: > > Does the IE infrastructure that you've added to the block layer invented for ufs? > Do you see other devices using it in the future? > > Today, chipset vendors are using a different scheme for their IE. > Need their ack before reviewing your patches. > Yes, as of today at least in Samsung HCI, we use additional HW blocks to handle all the crypto part. (Though I need to check the status on the recent SoCs). However given the fact that UFSHCI 2.1 spec does includes Crypto support, and going by threads that you shared, looks like other Vendors does uses IE. I am inclined toward getting this reviewed. > Thanks, > Avri
