RE: [PATCH 2/2] scsi: smartpqi: check sdev in pqi_scsi_find_entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Shane Seymour <shane.seymour@xxxxxxx>

> -----Original Message-----
> From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-
> owner@xxxxxxxxxxxxxxx] On Behalf Of mwilck@xxxxxxxx
> Sent: Wednesday, 17 June 2020 1:32 AM
> To: Don Brace <don.brace@xxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>
> Cc: esc.storagedev@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Martin
> Wilck <mwilck@xxxxxxxx>
> Subject: [PATCH 2/2] scsi: smartpqi: check sdev in pqi_scsi_find_entry
> 
> From: Martin Wilck <mwilck@xxxxxxxx>
> 
> If a scsi device has been destroyed e.g. using the sysfs "delete"
> attribute, subsequent host rescans won't re-discover it. This
> patch makes it work at least via the smartqpi-specific "rescan"
> sysfs attribute.
> 
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
>  drivers/scsi/smartpqi/smartpqi_init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
> b/drivers/scsi/smartpqi/smartpqi_init.c
> index 54a72f465f85..87089b67ff74 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -1612,7 +1612,8 @@ static enum pqi_find_result
> pqi_scsi_find_entry(struct pqi_ctrl_info *ctrl_info,
>  			device->scsi3addr)) {
>  			*matching_device = device;
>  			if (pqi_device_equal(device_to_find, device)) {
> -				if (device_to_find->volume_offline)
> +				if (device_to_find->volume_offline ||
> +				    !pqi_get_scsi_device(device))
>  					return DEVICE_CHANGED;
>  				return DEVICE_SAME;
>  			}
> --
> 2.26.2




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux