Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Daejun

On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote:
> +void ufsf_scan_features(struct ufs_hba *hba)
> +{
> +       int ret;
> +
> +       init_waitqueue_head(&hba->ufsf.sdev_wait);
> +       atomic_set(&hba->ufsf.slave_conf_cnt, 0);
> +
> +       if (hba->dev_info.wspecversion >= HPB_SUPPORTED_VERSION &&
> +           (hba->dev_info.b_ufs_feature_sup & UFS_DEV_HPB_SUPPORT)) 

How about removing this check "(hba->dev_info.wspecversion >=
HPB_SUPPORTED_VERSION" since ufs with lower version than v3.1 can add
HPB feature by FFU, 
if (hba->dev_info.b_ufs_feature_sup  &UFS_FEATURE_SUPPORT_HPB_BIT) is
enough.


> 
> +#define HPB_SUPPORTED_VERSION                  0x0310



Thank,
Bean




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux