On 6/5/20 5:32 PM, Don.Brace@xxxxxxxxxxxxx wrote:
git://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git reserved-tags.v3
As usual, comments and reviews are welcome.
I cloned your tree and ran some tests using hpsa.
I used 3 SATA HBA disks, 3 SAS HBA disks, 2 LOGICAL VOLUMES using HDDs, and 2 LOGICAL VOLUMES using SDDs for ioaccel path.
I have an IO stress test that does mkfs, mount/umount, fio, and fsck to the above volumes while doing sg_reset opeations in parallel.
The stress test has survived 2 full days of testing.
However, my insmod/rmmod test causes a kernel panic.
Not sure why yet. I had re-cloned yesterday an d the panic is still there.
Earlier kernel versions do not panic on rmmod.
--
2.16.4
Ah, right. Of course.
Should be fixed with this patch:\
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index fdc291c47b9b..87469908524c 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1885,9 +1885,9 @@ void scsi_forget_host(struct Scsi_Host *shost)
goto restart;
}
/* Remove virtual device last, might be needed to send commands */
+ spin_unlock_irqrestore(shost->host_lock, flags);
if (virtual_sdev)
__scsi_remove_device(virtual_sdev);
- spin_unlock_irqrestore(shost->host_lock, flags);
}
/**
Can you test with that?
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
