> > Maybe move this to after target_get_sess_cmd(). > > I moved it before target_get_sess_cmd() because if target_get_sess_cmd() fails > then we have NULL pointer dereference issue again. For instance, the sequence > vhost_scsi_submission_work > target_submit_cmd_map_sgls > target_get_sess_cmd() -- Suppose this fails > transport_send_check_condition_and_sense > trace_target_cmd_complete -- NULL ptr derefence. > > Still thinking how to address both these issues together. Also, noticed that not all callers of target_get_sess_cmd() check for return value.( iscsit_setup_scsi_cmd() and iscsit_handle_task_mgt_cmd()). Could this cause problems? -Sudhakar
