Hi all, based on the ideas from Doug Gilbert here's now my take on using xarrays for devices and targets. It revolves around two ideas: - The scsi target 'channel' and 'id' numbers are never ever used to the full 32 bit range; channels are well below 10, and no driver is using more than 16 bits for the id. So we can reduce the type of 'channel' and 'id' to 16 bits, and use the 32 bit value 'channel << 16 | id' as the index into the target xarray. - Nearly every target only ever uses the first two levels of the 4-level SCSI LUN structure, which means that we can use the linearized SCSI LUN id as an index into the xarray. If we ever come across targets utilizing more that 2 levels of the LUN structure we'll allocate the first unused index and have to resort to a less efficient lookup instead of direct indexing. With these changes we can implement an efficient lookup mechanism, devolving into direct lookup for most cases. It also allows us to detect duplicate entries or accidental overwrites of existing elements by using xa_cmpxchg(). And iteration over targets and devices should be as efficient as the current, list-based, approach. As usual, comments and reviews are welcome. Changes to v2: - Implement safe device iteration as noted by Doug - Add an additional patch to avoid a pointless memory allocation in scsi_alloc_target() Hannes Reinecke (6): scsi: convert target lookup to xarray target_core_pscsi: use __scsi_device_lookup() scsi: move target device list to xarray scsi: remove direct device lookup per host scsi_error: use xarray lookup instead of wrappers scsi: avoid pointless memory allocation in scsi_alloc_target() drivers/scsi/hosts.c | 5 +- drivers/scsi/scsi.c | 151 +++++++++++++++++++++++++++++-------- drivers/scsi/scsi_error.c | 35 +++++---- drivers/scsi/scsi_lib.c | 9 +-- drivers/scsi/scsi_priv.h | 2 + drivers/scsi/scsi_scan.c | 101 +++++++++++++++---------- drivers/scsi/scsi_sysfs.c | 72 +++++++++++++----- drivers/target/target_core_pscsi.c | 8 +- include/scsi/scsi_device.h | 32 +++++--- include/scsi/scsi_host.h | 5 +- 10 files changed, 288 insertions(+), 132 deletions(-) -- 2.16.4
