Hi Hannes, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next v5.7-rc7 next-20200529] [cannot apply to hch-configfs/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-use-xarray-for-devices-and-targets/20200531-083913 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>, old ones prefixed by <<): >> drivers/scsi/scsi_error.c:686:15: warning: variable 'starget' is uninitialized when used here [-Wuninitialized] xa_for_each(&starget->__devices, lun_idx, tmp_sdev) { ^~~~~~~ include/linux/xarray.h:497:20: note: expanded from macro 'xa_for_each' xa_for_each_start(xa, index, entry, 0) ^~ include/linux/xarray.h:473:20: note: expanded from macro 'xa_for_each_start' xa_for_each_range(xa, index, entry, start, ULONG_MAX) ^~ include/linux/xarray.h:445:23: note: expanded from macro 'xa_for_each_range' entry = xa_find(xa, &index, last, XA_PRESENT); ^~ drivers/scsi/scsi_error.c:679:29: note: initialize the variable 'starget' to silence this warning struct scsi_target *starget; ^ = NULL 1 warning generated. vim +/starget +686 drivers/scsi/scsi_error.c 675 676 static void scsi_handle_queue_full(struct scsi_device *sdev) 677 { 678 struct scsi_host_template *sht = sdev->host->hostt; 679 struct scsi_target *starget; 680 struct scsi_device *tmp_sdev; 681 unsigned long lun_idx = 0; 682 683 if (!sht->track_queue_depth) 684 return; 685 > 686 xa_for_each(&starget->__devices, lun_idx, tmp_sdev) { 687 if (tmp_sdev->sdev_state == SDEV_DEL) 688 continue; 689 /* 690 * We do not know the number of commands that were at 691 * the device when we got the queue full so we start 692 * from the highest possible value and work our way down. 693 */ 694 scsi_track_queue_full(tmp_sdev, tmp_sdev->queue_depth - 1); 695 } 696 } 697 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
