On Fri, May 29, 2020 at 08:50:21AM +0200, Hannes Reinecke wrote: > > I meant just use xa_alloc() for everything instead of using xa_insert for > > 0-255. > > > But then I'll have to use xa_find() to get to the actual element as the 1:1 > mapping between SCSI LUN and array index is lost. > And seeing that most storage arrays will expose only up to 256 LUNs I > thought this was a good improvement on lookup. > Of course, this only makes sense if xa_load() is more efficient than > xa_find(). If not then of course it's a bit futile. xa_load() is absolutely more efficient than xa_find(). It's just a question of whether it matters ;-) Carry on ...