Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-05-28 at 07:56 -0700, Bart Van Assche wrote:
> > -     buff_len = max_t(size_t, hba->desc_size.dev_desc,
> > -                      QUERY_DESC_MAX_SIZE + 1);
> > +     buff_len = QUERY_DESC_MAX_SIZE + 1;
> >        desc_buf = kmalloc(buff_len, GFP_KERNEL);
> >        if (!desc_buf) {
> >                err = -ENOMEM;
> 
> Since the buff_len variable is not changed after its initial
> assignment,
> please remove it entirely.
> 
> Thanks,
> 
> Bart.

hi, Bart

Thanks.

do you mean  like this: buff_len = hba->desc_size[id]?

Bean





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux