RE: [PATCH 3/3] target: rename target_setup_cmd_from_cdb() to target_parse_cdb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Maybe the naming would be nicer if we did:
> 
> target_init_cmd_cdb
> and
> target_parse_cmd_cdb
> 
> This would match each other's pattern and also match the style of the
> other cmd related function naming where its "target or transport"
> prefix, verb, cmd then optionally something extra.
> 
> Or maybe:
> 
> target_cmd_init_cdb
> and
> target_cmd_parse_cdb
> 
> so they at least match each other and you get an idea they pair together.
> 
> Just a suggestion and not a requirement, because I'm pretty bad at
> naming, so I have no idea if its better or not.
> 

Thank you Mike, Nice suggestion. I will incorporate the name change and send out another patch shortly.

Thanks
Sudhakar




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux