Hi Finn, On Wed, May 20, 2020 at 05:39:55PM +1000, Finn Thain wrote: > I agree. qla2xxx-endianness-annotations.diff seems to be noise. > > The differences in the __bug_table sections and ql_dbg() call sites are > presumably caused by line break changes. Perhaps they can be squelched by > inserting blank lines at the appropriate places (for either build). That > could probably be automated. Yes most of the noise is due to the ql_dbg() statemenents. I supppose the simplest way would to undefine it so no code is generated. > It would be nice to know how these symbols end up with different numbering > between builds because it makes a real mess of the diff. I am not sure what triggers the compiler to have different numberings. Mabye a newer gcc would behave better, no idea. I used the on shipped on SLE15-SP1, which means a bit older :) > I wonder whether the Reproducible Builds project has developed any > techniques that could be applied here. > https://reproducible-builds.org/ Maybe, I don't know if they tools from this project help for such an analysis. Well, I ended up going through the filtered diff. Obviously, with such a big diff it's easy to miss something but I don't think it's a problem. The patch got reviewes and the tools do also help to find bugs. Thanks, Daniel
