On 2020-05-15 03:30, Avri Altman wrote: > +static int ufshpb_attach(struct scsi_device *sdev) > +{ > + struct ufshpb_dh_data *h; > + > + h = kzalloc(sizeof(*h), GFP_KERNEL); > + if (!h) > + return SCSI_DH_NOMEM; > + > + sdev_printk(KERN_INFO, sdev, "%s: attached to sdev (lun) %llu\n", > + UFSHPB_NAME, sdev->lun); > + > + sdev->handler_data = h; > + > + return SCSI_DH_OK; > +} I think that all other SCSI device handlers check in their .attach function whether the @sdev SCSI device is supported by the device handler. I don't see any such check in the above function? Bart.