On Thu, May 14, 2020 at 02:35:14PM -0700, Bart Van Assche wrote:
> Cc: Arun Easi <aeasi@xxxxxxxxxxx>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Cc: Martin Wilck <mwilck@xxxxxxxx>
> Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 87d0f5e4d81a..0a9a838c7f20 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -819,7 +819,7 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
> goto skip_rio;
> switch (mb[0]) {
> case MBA_SCSI_COMPLETION:
> - handles[0] = le32_to_cpu((uint32_t)((mb[2] << 16) | mb[1]));
> + handles[0] = le32_to_cpu(make_handle(mb[2], mb[1]));
> handle_cnt = 1;
> break;
> case MBA_CMPLT_1_16BIT:
> @@ -858,10 +858,10 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
> mb[0] = MBA_SCSI_COMPLETION;
> break;
> case MBA_CMPLT_2_32BIT:
> - handles[0] = le32_to_cpu((uint32_t)((mb[2] << 16) | mb[1]));
> - handles[1] = le32_to_cpu(
> - ((uint32_t)(RD_MAILBOX_REG(ha, reg, 7) << 16)) |
> - RD_MAILBOX_REG(ha, reg, 6));
> + handles[0] = le32_to_cpu(make_handle(mb[2], mb[1]));
> + handles[1] =
> + le32_to_cpu(make_handle(RD_MAILBOX_REG(ha, reg, 7),
> + RD_MAILBOX_REG(ha, reg, 6)));
> handle_cnt = 2;
> mb[0] = MBA_SCSI_COMPLETION;
> break;
Hi Bart,
Reviewed-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
Thanks,
Roman
