Hi Bart,
On Thu, May 14, 2020 at 02:35:10PM -0700, Bart Van Assche wrote:
> Make qla27xx_write_remote_reg() easier to read by using register names
> instead of register offsets. The 'pahole' tool has been used to convert
> register offsets into register names. See also commit cbb01c2f2f63
> ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling").
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> Cc: Arun Easi <aeasi@xxxxxxxxxxx>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Cc: Martin Wilck <mwilck@xxxxxxxx>
> Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
This looks like a reasonable cleanup. I looked through the rest of the file
and the code is consistently using the same code pattern. It would be good
to keep it consistent. I am not against this change, I am just thinking
it would be good to fixup the complete file.
Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
Thanks,
Daniel
