On 2020-05-14 03:10, Nilesh Javali wrote:
> Please apply the qla2xxx patch series implementing SAN Congestion Management
> (SCM) support to the scsi tree at your earliest convenience.
Hi Nilesh,
This patch series introduces the following compiler warnings (W=1):
drivers/scsi/qla2xxx/qla_isr.c:27:1: warning: no previous prototype for
‘qla_link_integrity_tgt_stats_update’ [-Wmissing-prototypes]
27 | qla_link_integrity_tgt_stats_update(struct fpin_descriptor
*fpin_desc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:83:1: warning: no previous prototype for
‘qla_scm_process_link_integrity_d’ [-Wmissing-prototypes]
83 | qla_scm_process_link_integrity_d(struct scsi_qla_host *vha,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:143:1: warning: no previous prototype for
‘qla_delivery_tgt_stats_update’ [-Wmissing-prototypes]
143 | qla_delivery_tgt_stats_update(struct fpin_descriptor *fpin_desc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:173:1: warning: no previous prototype for
‘qla_scm_process_delivery_notification_d’ [-Wmissing-prototypes]
173 | qla_scm_process_delivery_notification_d(struct scsi_qla_host *vha,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:204:1: warning: no previous prototype for
‘qla_scm_set_target_device_state’ [-Wmissing-prototypes]
204 | qla_scm_set_target_device_state(fc_port_t *fcport,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:227:1: warning: no previous prototype for
‘qla_peer_congestion_tgt_stats_update’ [-Wmissing-prototypes]
227 | qla_peer_congestion_tgt_stats_update(struct fpin_descriptor
*fpin_desc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:270:1: warning: no previous prototype for
‘qla_scm_process_peer_congestion_notification_d’ [-Wmissing-prototypes]
270 | qla_scm_process_peer_congestion_notification_d(struct
scsi_qla_host *vha,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:313:1: warning: no previous prototype for
‘qla_scm_process_congestion_notification_d’ [-Wmissing-prototypes]
313 | qla_scm_process_congestion_notification_d(struct scsi_qla_host *vha,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:343:1: warning: no previous prototype for
‘qla27xx_process_purex_fpin’ [-Wmissing-prototypes]
343 | qla27xx_process_purex_fpin(struct scsi_qla_host *vha, struct
purex_item *item)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1136:1: warning: no previous prototype
for ‘qla24xx_alloc_purex_item’ [-Wmissing-prototypes]
1136 | qla24xx_alloc_purex_item(scsi_qla_host_t *vha, uint16_t size)
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1192:2: warning: no previous prototype
for ‘qla24xx_copy_std_pkt’ [-Wmissing-prototypes]
1192 | *qla24xx_copy_std_pkt(struct scsi_qla_host *vha, void *pkt)
| ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1213:1: warning: no previous prototype
for ‘qla27xx_copy_fpin_pkt’ [-Wmissing-prototypes]
1213 | qla27xx_copy_fpin_pkt(struct scsi_qla_host *vha, void **pkt,
| ^~~~~~~~~~~~~~~~~~~~~
CC [M] drivers/scsi/qla2xxx/qla_gs.o
CC [M] drivers/scsi/qla2xxx/qla_dbg.o
CC [M] drivers/scsi/qla2xxx/qla_sup.o
CC [M] drivers/scsi/qla2xxx/qla_attr.o
CC [M] drivers/scsi/qla2xxx/qla_mid.o
CC [M] drivers/scsi/qla2xxx/qla_dfs.o
drivers/scsi/qla2xxx/qla_dfs.c: In function
‘qla2x00_dfs_tgt_port_database_show’:
drivers/scsi/qla2xxx/qla_dfs.c:107:1: warning: the frame size of 1280
bytes is larger than 1024 bytes [-Wframe-larger-than=]
107 | }
| ^
and also the following sparse complaints:
$ make M=drivers/scsi/qla2xxx C=2
CHECK drivers/scsi/qla2xxx/qla_os.c
CC [M] drivers/scsi/qla2xxx/qla_os.o
CHECK drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_init.c:8520:22: warning: cast to restricted __le16
CC [M] drivers/scsi/qla2xxx/qla_init.o
CHECK drivers/scsi/qla2xxx/qla_mbx.c
CC [M] drivers/scsi/qla2xxx/qla_mbx.o
CHECK drivers/scsi/qla2xxx/qla_iocb.c
CC [M] drivers/scsi/qla2xxx/qla_iocb.o
CHECK drivers/scsi/qla2xxx/qla_isr.c
drivers/scsi/qla2xxx/qla_isr.c:27:1: warning: symbol
'qla_link_integrity_tgt_stats_update' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:106:38: warning: restricted __be32
degrades to integer
drivers/scsi/qla2xxx/qla_isr.c:83:1: warning: symbol
'qla_scm_process_link_integrity_d' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:143:1: warning: symbol
'qla_delivery_tgt_stats_update' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:173:1: warning: symbol
'qla_scm_process_delivery_notification_d' was not declared. Should it be
static?
drivers/scsi/qla2xxx/qla_isr.c:204:1: warning: symbol
'qla_scm_set_target_device_state' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:240:56: warning: incorrect type in
assignment (different base types)
drivers/scsi/qla2xxx/qla_isr.c:240:56: expected unsigned int
[usertype] event_period
drivers/scsi/qla2xxx/qla_isr.c:240:56: got restricted __be32
[usertype] event_period
drivers/scsi/qla2xxx/qla_isr.c:227:1: warning: symbol
'qla_peer_congestion_tgt_stats_update' was not declared. Should it be
static?
drivers/scsi/qla2xxx/qla_isr.c:270:1: warning: symbol
'qla_scm_process_peer_congestion_notification_d' was not declared.
Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:313:1: warning: symbol
'qla_scm_process_congestion_notification_d' was not declared. Should it
be static?
drivers/scsi/qla2xxx/qla_isr.c:343:1: warning: symbol
'qla27xx_process_purex_fpin' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1135:19: warning: symbol
'qla24xx_alloc_purex_item' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1192:1: warning: symbol
'qla24xx_copy_std_pkt' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1225:23: warning: restricted __le16
degrades to integer
drivers/scsi/qla2xxx/qla_isr.c:1225:23: warning: cast to restricted __le16
drivers/scsi/qla2xxx/qla_isr.c:1212:19: warning: symbol
'qla27xx_copy_fpin_pkt' was not declared. Should it be static?
CC [M] drivers/scsi/qla2xxx/qla_isr.o
CHECK drivers/scsi/qla2xxx/qla_gs.c
CC [M] drivers/scsi/qla2xxx/qla_gs.o
CHECK drivers/scsi/qla2xxx/qla_dbg.c
CC [M] drivers/scsi/qla2xxx/qla_dbg.o
CHECK drivers/scsi/qla2xxx/qla_sup.c
CC [M] drivers/scsi/qla2xxx/qla_sup.o
CHECK drivers/scsi/qla2xxx/qla_attr.c
CC [M] drivers/scsi/qla2xxx/qla_attr.o
CHECK drivers/scsi/qla2xxx/qla_mid.c
CC [M] drivers/scsi/qla2xxx/qla_mid.o
CHECK drivers/scsi/qla2xxx/qla_dfs.c
CC [M] drivers/scsi/qla2xxx/qla_dfs.o
drivers/scsi/qla2xxx/qla_dfs.c: In function
‘qla2x00_dfs_tgt_port_database_show’:
drivers/scsi/qla2xxx/qla_dfs.c:107:1: warning: the frame size of 1280
bytes is larger than 1024 bytes [-Wframe-larger-than=]
107 | }
| ^
Please fix these issues.
Thanks,
Bart.
