On Fri, 2020-05-08 at 11:38 +0000, Avri Altman wrote: > Hi Bean, > This patch is ~3,000 lines long. > Is it possible to divide it into a series of a smaller, more > reviewable patches? > E.g. it can be something like: > 1) Init part I - Read HPB config > 2) Init part II - prepare for L2P cache management (introduce here > all the new data structures, memory allocation, etc.) > 3) L2P cache management - activation / inactivation / eviction > handlers > 4) Add response API > 5) Add prep_fn handler - the flows that contruct HPB-READ command. > Or any other division that makes sense to you. > > Also, Is there a way to avoid all those #ifdefs everywhere? > > Thanks, > Avri > Hi, Avri Thanks. I will split it in the next version based on each different funcitonality. thanks, Bean
