On 5/1/20 7:39 PM, Christoph Hellwig wrote:
On Thu, Apr 30, 2020 at 03:18:25PM +0200, Hannes Reinecke wrote:
Add helper functions to retrieve SCSI commands from the reserved
tag pool.
I'm still quite worried about the fact that we have a pretty much
half-initialized command that now goes down the whole stack.
Reserved commands just serve as a placeholder to get a valid tag from
the block layer; the SCSI commands themselves are never ever passed
through the whole stack, but rather allocated internally within the
driver, and passed to the hardware by driver-specific means.
So really the SCSI specific parts of the commands are never used.
We can add a check in queuecommand to abort reserved commands if that's
what you worried about, though.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
