On 30/04/2020 14:19, Hannes Reinecke wrote:
Making this change is good.
/**
* pm8001_tag_alloc - allocate a empty tag for task used.
* @pm8001_ha: our hba struct
- * @tag_out: the found empty tag .
+ * @dev: device from which the tag should be allocated or NULL
*/
-inline int pm8001_tag_alloc(struct pm8001_hba_info *pm8001_ha, u32 *tag_out)
+inline u32 pm8001_tag_alloc(struct pm8001_hba_info *pm8001_ha,
+ struct domain_device *dev)
{
- unsigned int tag;
- void *bitmap = pm8001_ha->tags;
- unsigned long flags;
+ struct sas_task *task;
+ struct scsi_lun lun;
- spin_lock_irqsave(&pm8001_ha->bitmap_lock, flags);
- tag = find_first_zero_bit(bitmap, pm8001_ha->tags_num);
- if (tag >= pm8001_ha->tags_num) {
- spin_unlock_irqrestore(&pm8001_ha->bitmap_lock, flags);
- return -SAS_QUEUE_FULL;
- }
- set_bit(tag, bitmap);
- spin_unlock_irqrestore(&pm8001_ha->bitmap_lock, flags);
- *tag_out = tag;
- return 0;
-}
+ int_to_scsilun(0, &lun);
+ task = sas_alloc_slow_task(pm8001_ha->sas, dev,
+ &lun, GFP_KERNEL);
According to the current code in sas_alloc_slow_task(), we should now
set pm8001 shost->nr_reserved_cmds for this to work. Or always call
scsi_device_reserved_cmd() in sas_alloc_slow_task().
So even though the current code does not reserve commands, I would
prefer if it did, as good practice.
Thanks,
John
+ if (!task)
+ return -1;
-void pm8001_tag_init(struct pm8001_hba_info *pm8001_ha)
-{
- int i;
- for (i = 0; i < pm8001_ha->tags_num; ++i)
- pm8001_tag_free(pm8001_ha, i);
+ return task->tag;
}
/**
