On Mon, Apr 27, 2020 at 02:41:33PM -0400, Steven Rostedt wrote: > On Mon, 27 Apr 2020 10:15:48 +0200 > Daniel Wagner <dwagner@xxxxxxx> wrote: > > > > --- a/include/trace/events/qla.h > > > +++ b/include/trace/events/qla.h > > > @@ -9,6 +9,9 @@ > > > > > > #define QLA_MSG_MAX 256 > > > > > > +#pragma GCC diagnostic push > > > +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" > > > > I would be really surprised if this is needed for every single > > DECLARE_EVENT_CLASS declaration. > > > > > DECLARE_EVENT_CLASS(qla_log_event, > > > TP_PROTO(const char *buf, > > > struct va_format *vaf), > > Right. Looks like this warning is caused by the 'va_format' being passed to > the event prototype. Thanks for explaning. I had the impression the pragma is muting DECLARE_EVENT_CLASS. In this case Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
