On 4/28/20 11:43 AM, Bart Van Assche wrote: > On 2020-04-27 23:11, Mike Christie wrote: >> + ret = kobject_add(&se_sess->kobj, se_tpg->sessions_kobj, "session-%d", >> + se_sess->sid); >> + if (ret) { >> + pr_err("Could not add session%d to sysfs. Error %d.\n", >> + se_sess->sid, ret); >> + goto free_acl_name; >> + } > > Has it been considered to derive the directory name for a session from > the initiator name (se_node_acl.initiatorname-%d)? Would that be more > convenient for users than the session-%d naming scheme? It seems nicer. I can do the initaitorname-%d. It will also handle the iscsi case where we have multiple sessions from the same initiator to the same target port. > > Thanks, > > Bart. >