On 2020-04-27 02:18, Viacheslav Dubeyko wrote: > Hi Bart, > > On Sun, 2020-04-26 at 18:55 -0700, Bart Van Assche wrote: >> On 2020-04-24 05:10, Viacheslav Dubeyko wrote: >>> From: Viacheslav Dubeyko <v.dubeiko@xxxxxxxxx> >>> Date: Fri, 10 Apr 2020 11:07:08 +0300 >>> Subject: [PATCH 1/3] scsi: qla2xxx: Fix warning after FC target >>> reset >>> >>> Currently, FC target reset finishes with the warning >>> message. >> >> Hi Slava, >> >> For future patch submissions, please include a cover letter with the >> patch series and also use threaded mode, e.g. by setting >> sendemail.thread = true in ~/.gitconfig. >> >> A summary of what Martin Petersen expects from contributors is >> available >> at >> https://lore.kernel.org/ksummit-discuss/yq1o8zqeqhb.fsf@xxxxxxxxxx/. >> > > Frankly speaking, I don't see the logical relations among these three > fixes. So, I didn't prepare the cover letter because of this. I believe > that three independent patches could be better than patchset. What do > you think? Most people who are subscribed to kernel mailing lists use an e-mail client that supports threaded mode. Including a cover letter helps e-mail clients that support threaded mode a lot. > I am using the Evolution for sending the patches. I am not completely > sure that sendemail.thread = true in ~/.gitconfig can change the > Evolution's behavior. Is it something wrong with the Evolution's > settings? Please consider to use git send-email instead of Evolution. Most kernel developers use git branches to prepare patches. Using git send-email to send out a patch series from a git branch is much less work than copying these patches into Evolution and next telling Evolution to send out the patch series. Additionally, last time I used Evolution myself to send out patches I encountered a weird character encoding bug. I had to change character encoding from UTF-8 into UTF-7 to make sure that Evolution handles diacritics in names of people correctly. Bart.
