Looks good. Reviewed-by: Avri Altman <avri.altman@xxxxxxx> Thanks, Avri > v2 -> v3: > - Addressed Comments on refactoring > - Corrected the commit message > > v1 -> v2: > - Refactor WriteBooster initialization, introduce ufshcd_wb_probe() > - Refactor ufshcd_wb_keep_vcc_on() and introduce a new function > ufshcd_wb_presrv_usrspc_keep_vcc_on() > - Get the WriteBooster configuration by reading > bWriteBoosterBufferPreserveUserSpaceEn > > RFC -> v1: > - Added platform capability for WriteBooster > > RFC-: > v1 -> v2: > - Addressed comments on v1 > > - Supports shared buffer mode only > > - Didn't use exception event as suggested. > The reason being while testing I saw that the WriteBooster > available buffer remains at 0x1 for a longer time if flush is > enabled all the time as compared to an event-based enablement. > This essentially means that writes go to the WriteBooster buffer > more. Spec says that the if flush is enabled, the device would > flush when it sees the command queue empty. So I guess that'd trigger > flush more than an event based approach. > Anyway the Vcc would be turned-off during system suspend, so flush > would stop anyway. > In this patchset, I never turn-off flush. > Hence the RFC. > > Asutosh Das (3): > scsi: ufs: add write booster feature support > ufs-qcom: scsi: configure write booster type > ufs: sysfs: add sysfs entries for write booster > > drivers/scsi/ufs/ufs-qcom.c | 8 ++ > drivers/scsi/ufs/ufs-sysfs.c | 39 ++++++- > drivers/scsi/ufs/ufs.h | 37 ++++++- > drivers/scsi/ufs/ufshcd.c | 241 > ++++++++++++++++++++++++++++++++++++++++++- > drivers/scsi/ufs/ufshcd.h | 43 ++++++++ > 5 files changed, 362 insertions(+), 6 deletions(-) > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a > Linux Foundation Collaborative Project.
