On 4/21/2020 10:09 PM, Bart Van Assche wrote:
On 4/21/20 9:20 PM, James Smart wrote:
On 4/11/2020 9:57 PM, Bart Van Assche wrote:
On 2020-04-11 20:32, James Smart wrote:
+
+ lio_wq = create_singlethread_workqueue("efct_lio_worker");
+ if (!lio_wq) {
+ efc_log_err(efct, "workqueue create failed\n");
+ return -ENOMEM;
+ }
Is any work queued onto lio_wq that needs to be serialized against other
work queued onto the same queue? If not, can one of the system
workqueues be used, e.g. system_wq?
We are using "lio_wq" here to call the LIO backed during creation or
deletion of sessions. LIO api's target_remove_session/
target_setup_session are blocking calls so we don't want to process
them in the interrupt thread. "lio_wq" is used for these two events
only and this brings the serialization to session management as we
create single threaded work queue.
Hi James,
I think the above is very useful information. How about adding that
information as a comment above the definition of "lio_wq"?
Thanks,
Bart.
yep - we will. Thanks
-- james
