Hi Christoph, Your original patch always set the dma coherent mask to 32bit. But in this patch set, we first set the dma coherent to 64bit, if RDPQ pools crosses the 4gb boundary then we change it to 32 bit. Like your original patch we will simplify. Thanks, Suganath On Wed, Apr 22, 2020 at 12:04 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Wed, Apr 15, 2020 at 09:25:21AM -0400, Suganath Prabu wrote: > > From: Suganath Prabu S <suganath-prabu.subramani@xxxxxxxxxxxx> > > > > Currently driver is initially setting the dma coherent mask to 32 bit > > and then after allocating the Reply Descriptor Post Queues(RDPQ) pools > > it changes the dma coherent mask to 64/63 according to HBA generation. > > > > But the DMA layer does not allow changing the DMA coherent mask after > > there are outstanding allocations. > > > > So, updating the driver to stop changing the dma coherent mask after > > allocations. > > > > Rename ioc variable "dma_mask" to "is_dma_32bit" and use it to set 32 > > bit DMA. > > --- > > v1 Change log: > > 1) Incorporated the review comments from Christoph Hellwig > > > > Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@xxxxxxxxxxxx> > > I still don't see why you don't simply take my original patch instead.
