On Mon, Apr 20, 2020 at 10:46:21AM +0000, Johannes Thumshirn wrote: > On 18/04/2020 18:02, Bart Van Assche wrote: > > How about adding __must_check to scsi_setup_fs_cmnd()? > > I'm actually not sure if __must_check helps us anything given that with > this patch applied: It doesn't. __must_check on static functions with a single caller does not make any sense.