Re: [RFC PATCH 11/12] iscsi target: use session sysfs helpers

[Bodo Stroesser <bstroesser@xxxxxxxxxxxxxx>]

On 04/20/20 21:14, Mike Christie wrote:

...

> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index f533308..a0ea60f 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c

...

> @@ -313,7 +303,7 @@ static int iscsi_login_zero_tsih_s1(
>   				ISCSI_LOGIN_STATUS_NO_RESOURCES);
>   		pr_err("Unable to allocate memory for"
>   				" struct iscsi_sess_ops.\n");
> -		goto free_id;
> +		goto free_ops;

Shouldn' this be "goto free_sess;"?

>   	}
>   
>   	sess->se_sess = transport_alloc_session(TARGET_PROT_NORMAL);
> @@ -327,8 +317,6 @@ static int iscsi_login_zero_tsih_s1(
>   
>   free_ops:
>   	kfree(sess->sess_ops);
> -free_id:
> -	ida_free(&sess_ida, sess->session_index);
>   free_sess:
>   	kfree(sess);
>   	conn->sess = NULL;