On 04/20/2020 12:39 PM, Bodo Stroesser wrote:
>
>
> On 04/14/20 07:15, Mike Christie wrote:
>> +static ssize_t session_acl_show(struct se_session *se_sess, char *page)
>> +{
>> + struct se_node_acl *acl;
>> + ssize_t len;
>> +
>> + acl = se_sess->se_node_acl;
>> + if (!acl)
>> + return -ENOTCONN;
>> +
>> + if (acl->dynamic_node_acl) {
>> + page[0] = '\0';
>> + len = 0;
>> + } else {
>> + len = snprintf(page, PAGE_SIZE, "%s\n", acl->initiatorname);
>> + }
>> +
>> + return len;
>> +}
>
> Would it be a good idea to provide more info about initiators using
> dynamic acl?
>
> For example the file could be named "initiatorname" instead of "acl" and
I added this info in another dir/file. I was just about to post a update.
The acl is just a way to reference the configfs dir the info would be
located in since you can symlink.
> always provide the initiatorname, while a boolean file "acl" could
> return "Y" or "1" for explicit acls, but "N" or "0" for dynamic acls.
I was trying to not duplicate what is already in configfs.
