Hi Christoph, Thanks for your feedback. > -----Original Message----- > From: 'Christoph Hellwig' <hch@xxxxxxxxxxxxx> > Sent: 13 April 2020 19:09 > To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > Cc: 'Christoph Hellwig' <hch@xxxxxxxxxxxxx>; robh@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; krzk@xxxxxxxxxx; kwmad.kim@xxxxxxxxxxx; > avri.altman@xxxxxxx; cang@xxxxxxxxxxxxxx; 'Seungwon Jeon' > <essuuj@xxxxxxxxx>; stanley.chu@xxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for Exynos > SoCs > > On Sun, Apr 12, 2020 at 09:54:53PM +0530, Alim Akhtar wrote: > > > So this doesn't actually require the various removed or not added > > > quirks > > after > > > all? > > This driver is actual consumer of those quirks, so those are still needed. > > On Martin's 5.7/scsi-queue need to revert " 492001990f64 scsi: ufshcd: > > remove unused quirks" > > No. You need to include one patch per quirk in your series to add them back. Sure, will send the updated version soon. > Please also follow all proper kernel style guidelines, as the old code didn't > always follow the proper style.
