On Mon, Apr 13, 2020 at 10:24:37PM -0400, Martin K. Petersen wrote: > > Roman, > > >> - struct qla_fcp_prio_entry entry[1]; /* fcp priority entries */ > >> + struct qla_fcp_prio_entry entry[1023]; /* fcp priority entries */ > >> #define FCP_PRIO_CFG_ENTRY_SIZE 0x20 > >> + uint8_t reserved2[16]; > >> }; > >> > >> #define FCP_PRIO_CFG_SIZE (32*1024) /* fcp prio data per port*/ > > > > A new constant may be introduced to define size of qla_fcp_prio_entry. > > That would let to drop the magic 32 number here and allow to add one > > more BUILD_BUG_ON for sizeof(struct qla_fcp_prio_entry). > > I wonder what the firmware interface says about the runt entry? > Hi Martin, NVRAM and Option ROM contents/layout doesn't seem to be a part of the FW spec. Roman
