Fix a memory leak when there have failed, that we should free the pages under the condition rem_sz > 0. Signed-off-by: Li Bin <huawei.libin@xxxxxxxxxx> --- drivers/scsi/sg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 4e6af592..8441ac5 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1959,8 +1959,12 @@ static long sg_compat_ioctl(struct file *filp, unsigned int cmd_in, unsigned lon k, rem_sz)); schp->bufflen = blk_size; - if (rem_sz > 0) /* must have failed */ + if (rem_sz > 0) { /* must have failed */ + for (i = 0; i < k; i++) + __free_pages(schp->pages[i], order); + return -ENOMEM; + } return 0; out: for (i = 0; i < k; i++) -- 1.7.12.4