Markus, On Sun, Apr 05, 2020 at 10:02:47PM +0200, Markus Elfring wrote: > > NULL check before kfree is unnecessary so remove it. > > I hope that you would like to take another update suggestion into account > (besides a typo correction for your commit message). > https://lore.kernel.org/patchwork/patch/1220189/ > https://lore.kernel.org/linux-scsi/20200403164712.49579-1-alex.dewar@xxxxxxxxx/ I'm not sure I understand the relevance. Are you saying I should reference this other patch? > > Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary > checks before the function call "kfree"” also interesting? > https://lore.kernel.org/linux-scsi/54D3E057.9030600@xxxxxxxxxxxxxxxxxxxxx/ > https://lore.kernel.org/patchwork/patch/540593/ > https://lkml.org/lkml/2015/2/5/650 > Thanks for the reference. I'll mention it in the commit if I do a v2. Best, Alex > Regards, > Markus
