Hi Bart, > -----Original Message----- > From: Bart Van Assche <bvanassche@xxxxxxx> > Sent: Friday, April 3, 2020 7:46 PM > To: Nilesh Javali <njavali@xxxxxxxxxxx>; martin.petersen@xxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic- > Storage-Upstream@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH 1/2] qla2xxx: Fix regression warnings > > External Email > > ---------------------------------------------------------------------- > On 2020-04-03 01:40, Nilesh Javali wrote: > > @@ -2547,6 +2546,7 @@ ql_dbg(uint level, scsi_qla_host_t *vha, uint id, > const char *fmt, ...) > > vaf.va = &va; > > > > if (!ql_mask_match(level)) { > > + char pbuf[64]; > > if (vha != NULL) { > > const struct pci_dev *pdev = vha->hw->pdev; > > /* <module-name> <msg-id>:<host> Message */ > > Has this patch been verified witch checkpatch? Did checkpatch report > "Missing a blank line after declarations"? Yes, the patch was verified using checkpath and showed no warnings. Thanks, Nilesh