Re: [PATCH 3/3] qla2xxx: delete all sessions before unregister local nvme port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/27/2020 5:27 AM, Nilesh Javali wrote:
From: Quinn Tran <qutran@xxxxxxxxxxx>

Delete all sessions before unregistering local nvme port.  This
allows nvme layer to decrement all active rport count down to zero.
Once the count is down to zero, nvme would call qla to continue with
the npiv port deletion.

PID: 27448  TASK: ffff9e34b777c1c0  CPU: 0   COMMAND: "qaucli"
  0 [ffff9e25e84abbd8] __schedule at ffffffff977858ca
  1 [ffff9e25e84abc68] schedule at ffffffff97785d79
  2 [ffff9e25e84abc78] schedule_timeout at ffffffff97783881
  3 [ffff9e25e84abd28] wait_for_completion at ffffffff9778612d
  4 [ffff9e25e84abd88] qla_nvme_delete at ffffffffc0e3024e [qla2xxx]
  5 [ffff9e25e84abda8] qla24xx_vport_delete at ffffffffc0e024b9 [qla2xxx]
  6 [ffff9e25e84abdf0] fc_vport_terminate at ffffffffc011c247 [scsi_transport_fc]
  7 [ffff9e25e84abe28] store_fc_host_vport_delete at ffffffffc011cd94 [scsi_transport_fc]
  8 [ffff9e25e84abe70] dev_attr_store at ffffffff974b376b
  9 [ffff9e25e84abe80] sysfs_kf_write at ffffffff972d9a92
10 [ffff9e25e84abe90] kernfs_fop_write at ffffffff972d907b
11 [ffff9e25e84abec8] vfs_write at ffffffff9724c790
12 [ffff9e25e84abf08] sys_write at ffffffff9724d55f
13 [ffff9e25e84abf50] system_call_fastpath at ffffffff97792ed2
     RIP: 00007fc0bd81a6fd  RSP: 00007ffff78d9648  RFLAGS: 00010202
     RAX: 0000000000000001  RBX: 0000000000000022  RCX: 00007ffff78d96e0
     RDX: 0000000000000022  RSI: 00007ffff78d94e0  RDI: 0000000000000008
     RBP: 00007ffff78d9440   R8: 0000000000000000   R9: 00007fc0bd48b2cd
     R10: 0000000000000017  R11: 0000000000000293  R12: 0000000000000000
     R13: 00005624e4dac840  R14: 00005624e4da9a10  R15: 0000000000000000
     ORIG_RAX: 0000000000000001  CS: 0033  SS: 002b

Signed-off-by: Quinn Tran <qutran@xxxxxxxxxxx>
Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
---
  drivers/scsi/qla2xxx/qla_attr.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 3a5f6f27587e..4cfebf34ad7c 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -3055,11 +3055,11 @@ qla24xx_vport_delete(struct fc_vport *fc_vport)
  	    test_bit(FCPORT_UPDATE_NEEDED, &vha->dpc_flags))
  		msleep(1000);
- qla_nvme_delete(vha); qla24xx_disable_vp(vha);
  	qla2x00_wait_for_sess_deletion(vha);
+ qla_nvme_delete(vha);
  	vha->flags.delete_progress = 1;
qlt_remove_target(ha, vha);



Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux