Hi David, > -----Original Message----- > From: David Miller <davem@xxxxxxxxxxxxx> > Sent: Friday, March 27, 2020 12:05 AM > To: Saurav Kashyap <skashyap@xxxxxxxxxxx> > Cc: martin.petersen@xxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic- > Storage-Upstream@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH 5/8] qedf: Add schedule recovery handler. > > External Email > > ---------------------------------------------------------------------- > From: Saurav Kashyap <skashyap@xxxxxxxxxxx> > Date: Thu, 26 Mar 2020 00:08:03 -0700 > > > --- a/drivers/scsi/qedf/qedf_main.c > > +++ b/drivers/scsi/qedf/qedf_main.c > > @@ -3825,6 +3827,45 @@ static void qedf_shutdown(struct pci_dev > *pdev) > > __qedf_remove(pdev, QEDF_MODE_NORMAL); > > } > > > > +/* > > + * Recovery handler code > > + */ > > +void qedf_schedule_recovery_handler(void *dev) > ... > > +void qedf_recovery_handler(struct work_struct *work) > > These two functions are not referenced outside of this file, mark them > static. Thanks for feedback, will wait for other reviews and will submit v2. Thanks, ~Saurav