On Wed, 25 Mar 2020, 8:34am, Martin Wilck wrote:
> On Tue, 2020-03-24 at 17:36 -0700, Arun Easi wrote:
> > On Wed, 5 Feb 2020, 1:44pm, mwilck@xxxxxxxx wrote:
> >
> > > From: Martin Wilck <mwilck@xxxxxxxx>
> > >
> > > Since 45235022da99, the firmware is shut down early in the
> > > controller
> > > shutdown process. This causes commands sent to the firmware (such
> > > as LOGO)
> > > to hang forever. Eventually one or more timeouts will be triggered.
> > > Move the stopping of the firmware until after sessions have
> > > terminated.
> > >
> > > Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting
> > > down chip")
> > > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> > > ---
> > > drivers/scsi/qla2xxx/qla_os.c | 21 ++++++++++-----------
> > > 1 file changed, 10 insertions(+), 11 deletions(-)
> > >
> > >
>
> ...
>
> > NAK.
> >
> > The fcport deletion was done after chip reset to minimize interference
> > and further action on fcports. We should not be sending out logouts
> > during unload (driver just implicitly logs out). If you experience any
> > hangs, please let us know.
>
> What about target mode? AFAIK target ports need to send explicit LOGO.
>
I do not see a hard requirement cited in spec, correct me if you see
otherwise. Other initiators should see a RSCN and see this device has
gone away.
Regards,
-Arun
