Re: [PATCH v1 5/5] scsi: ufs: UFS Host Performance Booster(HPB) driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next next-20200320]
[cannot apply to v5.6-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/huobean-gmail-com/scsi-ufs-add-UFS-Host-Performance-Booster-HPB-driver/20200321-084331
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

>> ERROR: "__udivdi3" [drivers/scsi/ufs/ufshcd-core.ko] undefined!
>> ERROR: "__umoddi3" [drivers/scsi/ufs/ufshcd-core.ko] undefined!
--
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:15,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/blkdev.h:5,
                    from drivers/scsi/ufs/ufshpb.c:12:
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_lu_init':
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/linux/printk.h:310:9: note: in expansion of macro 'KERN_INFO'
     310 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~
>> drivers/scsi/ufs/ufshpb.h:28:2: note: in expansion of macro 'pr_info'
      28 |  pr_info("%s:" fmt, DRIVER_NAME, ##__VA_ARGS__)
         |  ^~~~~~~
>> drivers/scsi/ufs/ufshpb.c:2034:2: note: in expansion of macro 'hpb_info'
    2034 |  hpb_info("LU%d region table size: %lu bytes\n", lun,
         |  ^~~~~~~~
   drivers/scsi/ufs/ufshpb.c:2034:38: note: format string is defined here
    2034 |  hpb_info("LU%d region table size: %lu bytes\n", lun,
         |                                    ~~^
         |                                      |
         |                                      long unsigned int
         |                                    %u
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:15,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/blkdev.h:5,
                    from drivers/scsi/ufs/ufshpb.c:12:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/linux/printk.h:310:9: note: in expansion of macro 'KERN_INFO'
     310 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~
>> drivers/scsi/ufs/ufshpb.h:28:2: note: in expansion of macro 'pr_info'
      28 |  pr_info("%s:" fmt, DRIVER_NAME, ##__VA_ARGS__)
         |  ^~~~~~~
   drivers/scsi/ufs/ufshpb.c:2111:2: note: in expansion of macro 'hpb_info'
    2111 |  hpb_info("LU%d subregions info table takes memory %lu bytes\n", lun,
         |  ^~~~~~~~
   drivers/scsi/ufs/ufshpb.c:2111:54: note: format string is defined here
    2111 |  hpb_info("LU%d subregions info table takes memory %lu bytes\n", lun,
         |                                                    ~~^
         |                                                      |
         |                                                      long unsigned int
         |                                                    %u

vim +/pr_info +28 drivers/scsi/ufs/ufshpb.h

    20	
    21	#define UFSHPB_VER			0x0100
    22	#define DRIVER_NAME			"UFSHPB"
    23	#define hpb_warn(fmt, ...)					\
    24		pr_warn("%s:" fmt, DRIVER_NAME, ##__VA_ARGS__)
    25	#define hpb_notice(fmt, ...)					\
    26		pr_notice("%s:" fmt, DRIVER_NAME, ##__VA_ARGS__)
    27	#define hpb_info(fmt, ...)					\
  > 28		pr_info("%s:" fmt, DRIVER_NAME, ##__VA_ARGS__)
    29	#define hpb_err(fmt, ...)					\
    30		pr_err("%s: %s:" fmt, __func__, DRIVER_NAME,		\
    31						##__VA_ARGS__)
    32	#define hpb_dbg(level, hpb, fmt, ...)				\
    33	do {								\
    34		if (hpb == NULL)					\
    35			break;						\
    36		if (hpb->debug >= HPB_DBG_MAX || hpb->debug == level)	\
    37			pr_notice("%s: %s():" fmt,			\
    38				DRIVER_NAME, __func__, ##__VA_ARGS__);	\
    39	} while (0)
    40	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux