From: Christoph Hellwig <hch@xxxxxxxxxxxxx> Subject: Re: [PATCH 1/3] block: export blk_verify_command for SG v4 Date: Tue, 2 Jan 2007 11:49:16 +0000 > On Sat, Dec 16, 2006 at 12:18:23AM +0900, FUJITA Tomonori wrote: > > blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to > > be exported. > > So fixup blk_fill_sghdr_rq to deal with SG v4 aswell. We really > need to support all SGv4 features in the core code - bsg should > only be a small wrapper around core functionality at the end. Should blk_fill_sghdr_rq take cmd pointer, cmd_len, timeout, etc instead of sg_io_hdr structure? > And while you're touching this code, is there any chance you could > unifity the command permission tables for the block layer code and > the sg driver? This has been long overdue. No problem. You refer to unifying allow_ops in drivers/scsi/sg.c and blk_verify_command in block/scsi_ioctl.c, right? > doug has a nice document somewhere that documents the differences > between command allowances for the block layer vs the sg driver. > Please go through these and take the more resonable version for > each command. SCSI command permissions: http://sg.torque.net/sg/sg_io.html You mean that the sg driver and the block layer code share the same tables (might break some user-space code)? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
