Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>
Subject: Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 13 Mar 2020 12:06:12 +0100
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, Felipe Balbi <balbi@xxxxxxxxxx>, Harvey Harrison <harvey.harrison@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20200313023718.21830-4-bvanassche@acm.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Mar 12, 2020 at 07:37:16PM -0700, Bart Van Assche wrote:
> Move the get_unaligned_be24(), get_unaligned_le24() and
> put_unaligned_le24() definitions from various drivers into
> include/linux/unaligned/generic.h. Add a put_unaligned_be24()
> implementation.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

(although the added consts suggested by Andy look useful to me)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v2 0/5] Consolidate {get,put}_unaligned_[bl]e24() definitions
  - From: Bart Van Assche
- [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions
  - From: Bart Van Assche

Prev by Date: Re: [PATCH v2 1/5] linux/unaligned/byteshift.h: Remove superfluous casts
Next by Date: Re: [PATCH v2 4/5] scsi/st: Use get_unaligned_be24() and sign_extend32()
Previous by thread: Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions
Next by thread: Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]