Randy Dunlap wrote: > On Fri, 29 Dec 2006 08:02:17 -0800 Sumant Patro wrote: > > See Documentation/SubmittingPatches: > Please include output of "diffstat -p1 -w70" so that we can easily see > the scope of the changes. > > and see Documentation/CodingStyle for comments below: > > >> diff -uprN linux-2.6.orig/drivers/scsi/megaraid/megaraid_mbox.c linux-2.6.new/drivers/scsi/megaraid/megaraid_mbox.c >> --- linux-2.6.orig/drivers/scsi/megaraid/megaraid_mbox.c 2006-12-28 09:56:04.000000000 -0800 >> +++ linux-2.6.new/drivers/scsi/megaraid/megaraid_mbox.c 2006-12-29 05:31:48.000000000 -0800 >> @@ -779,6 +780,22 @@ megaraid_init_mbox(adapter_t *adapter) >> goto out_release_regions; >> } >> >> + // initialize the mutual exclusion lock for the mailbox >> + spin_lock_init(&raid_dev->mailbox_lock); > > Linux uses /*...*/ C89-style comments, not // C99 comments. Randy It is about time this absurd stipulation was dropped. Are there any C compilers that can compile the linux kernel and that don't accept both _standard_ comment styles? Doug Gilbert - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
