On 2020-03-07 18:10, Randy Dunlap wrote: > Would you (anyone) rather see something different here, > such as using pr_debug() or no_printk() instead of an > empty do-while loop? > > I went with a minimal change, but I can do something else > if that is preferred. If "do {} while(0)" is changed into "no_printk x", feel free to add the following: Reviewed-by: Bart van Assche <bvanassche@xxxxxxx>