On 24/02/2020 21:20, Merlijn B.W. Wajer wrote: > Just wanted to check if you planned to apply this v2 (you tried to apply > v1 but it didn't compile, so I rebased it onto 5.7/scsi-queue as you > requested). Please let me know if there's anything you'd like to see > changed. There's a missing call to mutex_destroy(&cd->lock) in sr_probe() if there are any failures after calling mutex_init(&cd->lock). > On 18/02/2020 20:21, Merlijn B.W. Wajer wrote: >> Perhaps I or someone else can work on removing the usage of the locks, >> but as it stands I think this addresses the performance issue present in >> the current kernel, and removing locks and the associated testing >> required with that is something I am not entirely comfortable doing. I have a patch to move the locks into the cdrom driver and I've got multiple PATA drives to test it with. -- Simon Arlott
