On 2020-03-03 06:10, Himanshu Madhani wrote: > On 3/3/20, 12:36 AM, "linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of Bart Van Assche" <linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of bvanassche@xxxxxxx> wrote: > On 2020-03-02 10:40, Daniel Wagner wrote: > > Isn't this assuming the host runs in little endian mode? Because later down... > > My goal was not to change the behavior of the code on x86. Bugs on big > endian systems can be fixed later on (my guess is that this driver does > not work reliably on big endian), and searching through the code for > __force casts probably provides some good starting points. > > We had made sure driver works on big endian system and the reason these were not changed was to make sure it does not break big endian architecture. It's been a few years since I verified big endian compatibility with the driver, but I am hesitant to go change things without making sure it works on big endian systems. We are taking big risk of blindly changing things. > > I'll ask our testing folks to test this out and see if we discover issue with these changes. Until then I'll hold off on Accepting changes. Thanks Himanshu for having offered to test this series. Please use v2 of this series as the basis for any tests. Bart.
