On 2/26/20 6:39 PM, Christoph Hellwig wrote:
On Thu, Feb 13, 2020 at 03:04:11PM +0100, Hannes Reinecke wrote:
extern void scsi_host_put(struct Scsi_Host *t);
extern struct Scsi_Host *scsi_host_lookup(unsigned short);
extern const char *scsi_host_state_name(enum scsi_host_state);
+extern void scsi_host_complete_all_commands(struct Scsi_Host *shost, int status);
This adds an > 80 char line. And externs on function declarations in
headers are never needed anyway.
As for the "extern": I'm just following what all the other function
declarations in the header file do.
If your argument is valid it would apply to all declarations in this
file, not just this one.
And that would be a separate patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer