On Fri, Feb 21, 2020 at 06:45:37PM -0800, Bart Van Assche wrote: > On 2020-02-21 10:18, Asutosh Das (asd) wrote: > > On 2/21/2020 6:08 AM, Christoph Hellwig wrote: > >> + /* Interrupt aggregation support is broken */ > >> + UFSHCD_QUIRK_BROKEN_INTR_AGGR = 1 << 0, > >> + > > > > How about using BIT() here? > > Not everyone is convinced that using BIT() improves code readability. I for one am not. 1 << N shoud be obvious to anyone with a basic understanding of C code, BIT() needs to be looked up. And it isn't actually any shorter.
