On 20/02/2020 21:09, Douglas Gilbert wrote: > +enum sdebug_z_cond { /* enumeration names taken from table 12, zbc2r04 */ > + zbc_not_write_pointer = 0x0, /* not in table 12; conventional zone */ > + zc1_empty = 0x1, > + zc2_implicit_open, > + zc3_explicit_open, > + zc4_closed, > + zc5_full = 0xe, /* values per Zone Condition field in Report Zones */ > + zc6_read_only = 0xd, > + zc7_offline = 0xf, > +}; Haven't checked the rest of scsi_debug, but I'd write these enum values in all caps. Furthermore I'd just call them EMPTY, OPEN, READ_ONLY, FULL, OFFLINE, etc..