Re: [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices

Can Guo <cang@xxxxxxxxxxxxxx> · Thu, 20 Feb 2020 14:34:39 +0800

On 2020-02-20 14:20, Avri Altman wrote:
Hi,


 /**
  * ufs_dev_fix - ufs device quirk info

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1fe0a97..a066f00 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = {
                UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),
        UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1" /*H28U62301AMR*/,
                UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME),
+       UFS_FIX(UFS_VENDOR_WDC, UFS_ANY_MODEL,
+               UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
We are objecting to apply this quirk categorically for all SOC vendors.
Please use a vendor-specific quirk for that.

Thanks,
Avri

Yeah, as we discussed, I will apply it in ufshcd_vops_apply_dev_quirks()
in next version and this is agreed by Stanley as well.






