On Tue, Feb 18, 2020 at 03:44:49PM -0800, Christoph Hellwig wrote: > static inline void ufshcd_utrl_clear(struct ufs_hba *hba, u32 pos) > { > - if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR) > - ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR); > - else > - ufshcd_writel(hba, ~(1 << pos), > - REG_UTP_TRANSFER_REQ_LIST_CLEAR); > + ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR); > } This part is keeping the quirk version. It needs to be other way around. - Eric