Hi Ming, Thank you for the patch! Yet something to improve: [auto build test ERROR on scsi/for-next] [also build test ERROR on mkp-scsi/for-next block/for-next v5.6-rc1 next-20200213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Ming-Lei/scsi-tracking-device-queue-depth-via-sbitmap/20200213-215727 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-4) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): In file included from drivers/message/fusion/mptbase.h:839:0, from drivers/message/fusion/mptsas.c:63: drivers/message/fusion/mptsas.c: In function 'mptsas_send_link_status_event': >> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'? atomic_read(&sdev->device_busy))); ^ drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING' CMD; \ ^~~ >> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk' devtprintk(ioc, ^~~~~~~~~~ vim +3759 drivers/message/fusion/mptsas.c e6b2d76a49f0ee4 Moore, Eric 2006-03-14 3675 0c33b27deb93178 Christoph Hellwig 2005-09-09 3676 static void f9c34022eae9c76 Kashyap, Desai 2009-05-29 3677 mptsas_send_link_status_event(struct fw_event_work *fw_event) 0c33b27deb93178 Christoph Hellwig 2005-09-09 3678 { f9c34022eae9c76 Kashyap, Desai 2009-05-29 3679 MPT_ADAPTER *ioc; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3680 MpiEventDataSasPhyLinkStatus_t *link_data; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3681 struct mptsas_portinfo *port_info; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3682 struct mptsas_phyinfo *phy_info = NULL; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3683 __le64 sas_address; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3684 u8 phy_num; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3685 u8 link_rate; 0c33b27deb93178 Christoph Hellwig 2005-09-09 3686 f9c34022eae9c76 Kashyap, Desai 2009-05-29 3687 ioc = fw_event->ioc; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3688 link_data = (MpiEventDataSasPhyLinkStatus_t *)fw_event->event_data; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3689 f9c34022eae9c76 Kashyap, Desai 2009-05-29 3690 memcpy(&sas_address, &link_data->SASAddress, sizeof(__le64)); f9c34022eae9c76 Kashyap, Desai 2009-05-29 3691 sas_address = le64_to_cpu(sas_address); f9c34022eae9c76 Kashyap, Desai 2009-05-29 3692 link_rate = link_data->LinkRates >> 4; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3693 phy_num = link_data->PhyNum; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3694 f9c34022eae9c76 Kashyap, Desai 2009-05-29 3695 port_info = mptsas_find_portinfo_by_sas_address(ioc, sas_address); f9c34022eae9c76 Kashyap, Desai 2009-05-29 3696 if (port_info) { f9c34022eae9c76 Kashyap, Desai 2009-05-29 3697 phy_info = &port_info->phy_info[phy_num]; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3698 if (phy_info) f9c34022eae9c76 Kashyap, Desai 2009-05-29 3699 phy_info->negotiated_link_rate = link_rate; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3700 } f9c34022eae9c76 Kashyap, Desai 2009-05-29 3701 f9c34022eae9c76 Kashyap, Desai 2009-05-29 3702 if (link_rate == MPI_SAS_IOUNIT0_RATE_1_5 || d75733d51fdab5c Kashyap, Desai 2011-02-10 3703 link_rate == MPI_SAS_IOUNIT0_RATE_3_0 || d75733d51fdab5c Kashyap, Desai 2011-02-10 3704 link_rate == MPI_SAS_IOUNIT0_RATE_6_0) { f9c34022eae9c76 Kashyap, Desai 2009-05-29 3705 eedf92b99806aef Kashyap, Desai 2009-05-29 3706 if (!port_info) { eedf92b99806aef Kashyap, Desai 2009-05-29 3707 if (ioc->old_sas_discovery_protocal) { eedf92b99806aef Kashyap, Desai 2009-05-29 3708 port_info = mptsas_expander_add(ioc, eedf92b99806aef Kashyap, Desai 2009-05-29 3709 le16_to_cpu(link_data->DevHandle)); eedf92b99806aef Kashyap, Desai 2009-05-29 3710 if (port_info) eedf92b99806aef Kashyap, Desai 2009-05-29 3711 goto out; eedf92b99806aef Kashyap, Desai 2009-05-29 3712 } f44e5461d919a34 Moore, Eric 2006-03-14 3713 goto out; eedf92b99806aef Kashyap, Desai 2009-05-29 3714 } f9c34022eae9c76 Kashyap, Desai 2009-05-29 3715 f9c34022eae9c76 Kashyap, Desai 2009-05-29 3716 if (port_info == ioc->hba_port_info) f9c34022eae9c76 Kashyap, Desai 2009-05-29 3717 mptsas_probe_hba_phys(ioc); f9c34022eae9c76 Kashyap, Desai 2009-05-29 3718 else f9c34022eae9c76 Kashyap, Desai 2009-05-29 3719 mptsas_expander_refresh(ioc, port_info); f9c34022eae9c76 Kashyap, Desai 2009-05-29 3720 } else if (phy_info && phy_info->phy) { f9c34022eae9c76 Kashyap, Desai 2009-05-29 3721 if (link_rate == MPI_SAS_IOUNIT0_RATE_PHY_DISABLED) f9c34022eae9c76 Kashyap, Desai 2009-05-29 3722 phy_info->phy->negotiated_linkrate = f9c34022eae9c76 Kashyap, Desai 2009-05-29 3723 SAS_PHY_DISABLED; f9c34022eae9c76 Kashyap, Desai 2009-05-29 3724 else if (link_rate == f9c34022eae9c76 Kashyap, Desai 2009-05-29 3725 MPI_SAS_IOUNIT0_RATE_FAILED_SPEED_NEGOTIATION) f9c34022eae9c76 Kashyap, Desai 2009-05-29 3726 phy_info->phy->negotiated_linkrate = f9c34022eae9c76 Kashyap, Desai 2009-05-29 3727 SAS_LINK_RATE_FAILED; c9de7dc48307395 Kashyap, Desai 2010-07-26 3728 else { f9c34022eae9c76 Kashyap, Desai 2009-05-29 3729 phy_info->phy->negotiated_linkrate = f9c34022eae9c76 Kashyap, Desai 2009-05-29 3730 SAS_LINK_RATE_UNKNOWN; c9de7dc48307395 Kashyap, Desai 2010-07-26 3731 if (ioc->device_missing_delay && c9de7dc48307395 Kashyap, Desai 2010-07-26 3732 mptsas_is_end_device(&phy_info->attached)) { c9de7dc48307395 Kashyap, Desai 2010-07-26 3733 struct scsi_device *sdev; c9de7dc48307395 Kashyap, Desai 2010-07-26 3734 VirtDevice *vdevice; c9de7dc48307395 Kashyap, Desai 2010-07-26 3735 u8 channel, id; c9de7dc48307395 Kashyap, Desai 2010-07-26 3736 id = phy_info->attached.id; c9de7dc48307395 Kashyap, Desai 2010-07-26 3737 channel = phy_info->attached.channel; c9de7dc48307395 Kashyap, Desai 2010-07-26 3738 devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT c9de7dc48307395 Kashyap, Desai 2010-07-26 3739 "Link down for fw_id %d:fw_channel %d\n", c9de7dc48307395 Kashyap, Desai 2010-07-26 3740 ioc->name, phy_info->attached.id, c9de7dc48307395 Kashyap, Desai 2010-07-26 3741 phy_info->attached.channel)); c9de7dc48307395 Kashyap, Desai 2010-07-26 3742 c9de7dc48307395 Kashyap, Desai 2010-07-26 3743 shost_for_each_device(sdev, ioc->sh) { c9de7dc48307395 Kashyap, Desai 2010-07-26 3744 vdevice = sdev->hostdata; c9de7dc48307395 Kashyap, Desai 2010-07-26 3745 if ((vdevice == NULL) || c9de7dc48307395 Kashyap, Desai 2010-07-26 3746 (vdevice->vtarget == NULL)) c9de7dc48307395 Kashyap, Desai 2010-07-26 3747 continue; c9de7dc48307395 Kashyap, Desai 2010-07-26 3748 if ((vdevice->vtarget->tflags & c9de7dc48307395 Kashyap, Desai 2010-07-26 3749 MPT_TARGET_FLAGS_RAID_COMPONENT || c9de7dc48307395 Kashyap, Desai 2010-07-26 3750 vdevice->vtarget->raidVolume)) c9de7dc48307395 Kashyap, Desai 2010-07-26 3751 continue; c9de7dc48307395 Kashyap, Desai 2010-07-26 3752 if (vdevice->vtarget->id == id && c9de7dc48307395 Kashyap, Desai 2010-07-26 3753 vdevice->vtarget->channel == c9de7dc48307395 Kashyap, Desai 2010-07-26 3754 channel) c9de7dc48307395 Kashyap, Desai 2010-07-26 @3755 devtprintk(ioc, c9de7dc48307395 Kashyap, Desai 2010-07-26 3756 printk(MYIOC_s_DEBUG_FMT c9de7dc48307395 Kashyap, Desai 2010-07-26 3757 "SDEV OUTSTANDING CMDS" c9de7dc48307395 Kashyap, Desai 2010-07-26 3758 "%d\n", ioc->name, 71e75c97f97a964 Christoph Hellwig 2014-04-11 @3759 atomic_read(&sdev->device_busy))); c9de7dc48307395 Kashyap, Desai 2010-07-26 3760 } c9de7dc48307395 Kashyap, Desai 2010-07-26 3761 c9de7dc48307395 Kashyap, Desai 2010-07-26 3762 } c9de7dc48307395 Kashyap, Desai 2010-07-26 3763 } f44e5461d919a34 Moore, Eric 2006-03-14 3764 } f44e5461d919a34 Moore, Eric 2006-03-14 3765 out: f9c34022eae9c76 Kashyap, Desai 2009-05-29 3766 mptsas_free_fw_event(ioc, fw_event); e6b2d76a49f0ee4 Moore, Eric 2006-03-14 3767 } e6b2d76a49f0ee4 Moore, Eric 2006-03-14 3768 :::::: The code at line 3759 was first introduced by commit :::::: 71e75c97f97a9645d25fbf3d8e4165a558f18747 scsi: convert device_busy to atomic_t :::::: TO: Christoph Hellwig <hch@xxxxxx> :::::: CC: Christoph Hellwig <hch@xxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
